HDFS-16462. Make HDFS get tool cross platform#4003
Merged
GauthamBanasandra merged 5 commits intoapache:trunkfrom Mar 5, 2022
Merged
HDFS-16462. Make HDFS get tool cross platform#4003GauthamBanasandra merged 5 commits intoapache:trunkfrom
GauthamBanasandra merged 5 commits intoapache:trunkfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
goiri
approved these changes
Feb 21, 2022
f53d0bf to
c29a231
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
c29a231 to
a543712
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
a543712 to
40e9eaa
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The source files for
hdfs_getusesgetoptfor parsing the command line arguments. getopt is available only on Linux and thus, isn't cross platform. We need to replace getopt withboost::program_optionsto make these tools cross platform.hdfs_gethas the same functionality ashdfs_copyToLocal. Thus, we're reusing the same to implementhdfs_get.How was this patch tested?
Given that
hdfs_gethas the same functionality ashdfs_copyToLocal, we've implementedhdfs::tools::Getby deriving fromhdfs::tools::CopyToLocal. Since we've already testedhdfs::tools::CopyToLocalfor functional correctness, we don't need to do any additional testing to validate the same forhdfs::tools::Get.However, we do ensure that the correct tool name shows up for
hdfs_copyToLocalandhdfs_get.hdfs_copyToLocal
hdfs_get
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?